whatdotheyknow-theme icon indicating copy to clipboard operation
whatdotheyknow-theme copied to clipboard

Accessibility issues: WDTK

Open lucascumsille opened this issue 2 years ago • 5 comments

This pull request contains some fixes for accessibility issues found in the WDTK theme.

$color_blue is now a darker, richer version that passes the contrast test:

Screenshot 2022-04-21 at 07 36 10 Screenshot 2022-04-21 at 07 35 45 Screenshot 2022-04-21 at 07 35 28

Items on subnav pass contrast test

Screenshot 2022-04-21 at 08 27 40

Secondary button a bit darker

Screenshot 2022-04-21 at 08 50 38

Increase vertical padding for list items on help page

Screenshot 2022-04-21 at 07 37 53

When creating a new request the footer notes now pass the contrast test

Screenshot 2022-04-21 at 07 40 26

Fixes part of: #1138 The rest of the issues, will be fixed on the Alaveteli core.

lucascumsille avatar Apr 21 '22 06:04 lucascumsille

This pull request contains some fixes for accessibility issues found in the WDTK theme. [snip…]

Just to note, and definitely not a review - I actually really like this - it has the secondary advantage of refreshing the design in a subtle way, whilst delivering known access benefits. Lovely stuff 👍

mdeuk avatar Apr 21 '22 09:04 mdeuk

I'm thinking we merge and deploy this when we start talking about our 20th anniversary. Am I correct in thinking there will be a banner added to WDTK for this?

gbp avatar Feb 02 '23 11:02 gbp

I'm thinking we merge and deploy this when we start talking about our 20th anniversary

Sounds good.

Am I correct in thinking there will be a banner added to WDTK for this?

Looks like its on its way https://github.com/mysociety/Design-Internal-tasks/issues/8#issuecomment-1410057767

garethrees avatar Feb 02 '23 12:02 garethrees

Looks like its on its way https://github.com/mysociety/Design-Internal-tasks/issues/8#issuecomment-1410057767

I can't see that one, but I will link this to a couple of related tickets, so we've got them together:

  • https://github.com/mysociety/whatdotheyknow-theme/issues/1545
  • https://github.com/mysociety/whatdotheyknow-theme/issues/1571

mdeuk avatar Feb 02 '23 12:02 mdeuk

@gbp let's get this rebased & merged (finally! 😅)

garethrees avatar Apr 19 '24 09:04 garethrees