fixmystreet icon indicating copy to clipboard operation
fixmystreet copied to clipboard

[Bexley][WW] Allow reporting missed collections

Open nephila-nacrea opened this issue 1 year ago • 1 comments

Adds the necessary checks, templates and hooks to allow reporting missed collections to Whitespace.

Handles the gate checks that need to be done before the report can be submitted:

  • Check for existing open reports
  • Check that the collection happened in the past 3 working days
  • Check the in-cab logs for red tags and service updates

I've also added a superuser-only section at the bottom of the services screen to allow superusers to view the "raw" in-cab logs (red tags and service exceptions), as I think that might be useful in the future.

Closes https://github.com/mysociety/societyworks/issues/4094.

[skip changelog]

nephila-nacrea avatar Feb 22 '24 16:02 nephila-nacrea

Codecov Report

Attention: Patch coverage is 65.95745% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 82.59%. Comparing base (395ea66) to head (7fb2faa).

Files Patch % Lines
perllib/FixMyStreet/Cobrand/Bexley/Waste.pm 79.48% 10 Missing and 6 partials :warning:
perllib/Integrations/Whitespace.pm 0.00% 16 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4856      +/-   ##
==========================================
- Coverage   82.64%   82.59%   -0.05%     
==========================================
  Files         387      387              
  Lines       30347    30434      +87     
  Branches     4787     4804      +17     
==========================================
+ Hits        25080    25138      +58     
- Misses       3825     3847      +22     
- Partials     1442     1449       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 22 '24 16:02 codecov[bot]

I assume this will all be squashed together given the changes

Yep will squash it all together once it's been reviewed.

I see the 'last collection' is also added as part of this which I don't think was there before, that might be worth noting in the commit message as well.

Have amended the commit message (but made the requested changes in a separate fixup commit).

chrismytton avatar Mar 05 '24 16:03 chrismytton