fixmystreet icon indicating copy to clipboard operation
fixmystreet copied to clipboard

[TfL] Initialise single sign on

Open MorayMySoc opened this issue 1 year ago • 2 comments

Adding single sign on for TfL staff

[skip changelog]

MorayMySoc avatar Jan 08 '24 11:01 MorayMySoc

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (0eac24d) 85.34% compared to head (1526319) 75.67%. Report is 39 commits behind head on master.

:exclamation: Current head 1526319 differs from pull request most recent head 6574c7e. Consider uploading reports for the commit 6574c7e to get more accurate results

Files Patch % Lines
perllib/FixMyStreet/Cobrand/TfL.pm 9.52% 18 Missing and 1 partial :warning:
perllib/FixMyStreet/App/Controller/Auth/Social.pm 33.33% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4783      +/-   ##
==========================================
- Coverage   85.34%   75.67%   -9.67%     
==========================================
  Files         341      342       +1     
  Lines       24647    25363     +716     
  Branches     4673     4894     +221     
==========================================
- Hits        21035    19194    -1841     
- Misses       2191     4686    +2495     
- Partials     1421     1483      +62     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 08 '24 11:01 codecov[bot]

I've updated server side to follow the pattern of the sigin/token urls

MorayMySoc avatar Jan 08 '24 15:01 MorayMySoc

@MorayMySoc Can this be closed now https://github.com/mysociety/fixmystreet/pull/4796 has been merged?

chrismytton avatar Mar 15 '24 09:03 chrismytton

As above - this will not be merged as was superseded by https://github.com/mysociety/fixmystreet/pull/4796

MorayMySoc avatar Mar 15 '24 09:03 MorayMySoc