fixmystreet
fixmystreet copied to clipboard
Incremental updates
Please check the following:
- [x] Whether this PR should include changes to any documentation, or the FAQ;
- [x] All cobrand-specific commits start their commit message with the cobrand in square brackets;
- [ ] Is new functionality tested? CodeCov will warn you about the diff coverage, but won’t complain about e.g. new files;
- [x] Will cobrand-specific changes require additional work to ensure consistent behaviour on www.fixmystreet.com?
- [x] Are the changes tested for accessibility?
- [ ] Have you updated the changelog? If this is not necessary, put square brackets around this: [skip changelog]
Please check the contributing docs, and describe your pull request here. Screenshots or GIF animations (using e.g. LICEcap) may be helpful.
Please include any issues that are fixed, using "fixes" or "closes" so that they are auto-closed when the PR is merged.
Thanks for contributing!
Codecov Report
Merging #4235 (defa01d) into master (0f51a2f) will increase coverage by
13.31%. The diff coverage is66.66%.
@@ Coverage Diff @@
## master #4235 +/- ##
===========================================
+ Coverage 69.95% 83.26% +13.31%
===========================================
Files 348 359 +11
Lines 25559 26559 +1000
Branches 3898 4120 +222
===========================================
+ Hits 17880 22115 +4235
+ Misses 6525 3199 -3326
- Partials 1154 1245 +91
| Impacted Files | Coverage Δ | |
|---|---|---|
| web/cobrands/fixmystreet/staff.js | 56.37% <66.66%> (-0.04%) |
:arrow_down: |
| perllib/FixMyStreet/App/Controller/Offline.pm | 90.00% <0.00%> (-7.83%) |
:arrow_down: |
| perllib/FixMyStreet/App/Controller/Auth/Social.pm | 75.00% <0.00%> (-3.24%) |
:arrow_down: |
| perllib/FixMyStreet/App/Form/Claims.pm | 82.50% <0.00%> (-0.84%) |
:arrow_down: |
| web/cobrands/fixmystreet/assets.js | 88.85% <0.00%> (-0.17%) |
:arrow_down: |
| web/cobrands/bathnes/staff.js | 100.00% <0.00%> (ø) |
|
| perllib/FixMyStreet/Cobrand/Lincolnshire.pm | 34.28% <0.00%> (ø) |
|
| web/cobrands/shropshire/assets.js | ||
| perllib/FixMyStreet/App/Form/Waste/Request/SLWP.pm | ||
| web/cobrands/bathnes/assets.js | ||
| ... and 163 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
ee7c78e48a88f559796b7ccc05e2751b887b4cd0 hides the PWA installation banner on FixaMinGata only. Do we want to make this the default behaviour?
0ef657d9b253662d8445694a6daf017126c537fd disables the translation banner for all FixMyStreet cobrands.
Closing in order to split up to smaller pull requests that are easier to merge.