fixmystreet
fixmystreet copied to clipboard
[PCC] Added reusable UI elements for Bulky waste request form
This PR includes elements that improves the user journey:
- Added secondary button, which has less emphasis than the primary one. It's good to use it next to the primary one so it
- Added a secondary button with less emphasis than the primary one. It's good to use it next to the primary one so it doesn't draw as much attention, but it's still fairly obvious is there. You can also use it on its own; when you want to show there is an action available but is not the most important part of the page.
- Added "Next" and "Back" buttons, which help with the page's scannability.
- Added an info message based on the GOVUK warning message. It can be used to provide non-vital information to the user, so if they decide to omit it, there won't be a big consequence. For example: "If you are a landlord, call this number". For instance, when NOT to use it, "You need to dismantle this item before collection". In this case, if the user ignores this message, there will be a consequence, the item won't get picked up.
Fixes: https://github.com/mysociety/societyworks/issues/3231
Codecov Report
Merging #4111 (5260dd4) into master (05b6d5c) will decrease coverage by
0.75%
. The diff coverage isn/a
.
:exclamation: Current head 5260dd4 differs from pull request most recent head 4a08747. Consider uploading reports for the commit 4a08747 to get more accurate results
@@ Coverage Diff @@
## master #4111 +/- ##
==========================================
- Coverage 82.93% 82.18% -0.76%
==========================================
Files 368 368
Lines 25574 25886 +312
Branches 3885 3989 +104
==========================================
+ Hits 21211 21275 +64
- Misses 3174 3408 +234
- Partials 1189 1203 +14
Impacted Files | Coverage Δ | |
---|---|---|
perllib/FixMyStreet/Roles/DDProcessor.pm | 55.88% <0.00%> (-31.10%) |
:arrow_down: |
perllib/FixMyStreet/Cobrand/Oxfordshire.pm | 62.31% <0.00%> (-20.41%) |
:arrow_down: |
perllib/FixMyStreet/Cobrand/Buckinghamshire.pm | 72.05% <0.00%> (-13.11%) |
:arrow_down: |
web/cobrands/highwaysengland/assets.js | 57.14% <0.00%> (-8.20%) |
:arrow_down: |
web/cobrands/merton/assets.js | 85.71% <0.00%> (-5.20%) |
:arrow_down: |
perllib/FixMyStreet/DB/Result/Problem.pm | 86.64% <0.00%> (-2.74%) |
:arrow_down: |
perllib/FixMyStreet/Cobrand/TfL.pm | 83.98% <0.00%> (-0.75%) |
:arrow_down: |
web/cobrands/fixmystreet/assets.js | 88.96% <0.00%> (-0.66%) |
:arrow_down: |
perllib/Open311.pm | 93.72% <0.00%> (+1.65%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@davea thanks again =) I just made both changes. Let me know if there is anything else you'd like me to change.
Thanks @davea should I merge it? or wait for Victoria?
Thanks @davea should I merge it? or wait for Victoria?
Should be OK to go ahead!