fixmystreet icon indicating copy to clipboard operation
fixmystreet copied to clipboard

[Lincolnshire] Pull in user information via Open311 so customers can receive updates

Open chrismytton opened this issue 2 years ago • 1 comments

Lincolnshire have requested that reports pulled in via Open311's GetServiceRequests are created using the user information stored in their backend system.

This is so that the reports created in FixMyStreet are associated with the email address of the original reporter so they can receive updates on reports.

Part of https://github.com/mysociety/societyworks/issues/3079

[skip changelog]

chrismytton avatar Sep 15 '22 18:09 chrismytton

Codecov Report

Merging #4110 (9a7843a) into master (0254d60) will decrease coverage by 12.04%. The diff coverage is n/a.

:exclamation: Current head 9a7843a differs from pull request most recent head 72398c9. Consider uploading reports for the commit 72398c9 to get more accurate results

@@             Coverage Diff             @@
##           master    #4110       +/-   ##
===========================================
- Coverage   82.60%   70.56%   -12.04%     
===========================================
  Files         363       42      -321     
  Lines       27371     4753    -22618     
  Branches     4256        0     -4256     
===========================================
- Hits        22609     3354    -19255     
+ Misses       3480     1399     -2081     
+ Partials     1282        0     -1282     

see 322 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 15 '22 18:09 codecov[bot]

~~@chrismytton I've added a safety check in 4ebadfcaf65f25f094b9a89edba7c3ace5b58791 to limit when we store contact information on staging sites. Can you give it a look please?~~ I'd forgotten you were off, Matthew checked it :)

davea avatar Nov 17 '22 21:11 davea

The code in this PR doesn't actually cause any logged email to be sent, as far as I can see, or for the pulled in user to be signed up for update alerts.

dracos avatar Dec 06 '22 14:12 dracos