fixmystreet
fixmystreet copied to clipboard
mysociety
[Oxfordshire] Add Parish and Districts to All Reports
- Adds Parish and District tabs on all reports for Oxfordshire
- Populates these with relevant Parish or Ward data
- Adds method to body to search for specific children data
- Adds a cobrand feature to allow initialising option
https://github.com/mysociety/societyworks/issues/2658
[skip changelog]
Codecov Report
Merging #3918 (ef2911a) into master (48084ff) will decrease coverage by
10.45%. The diff coverage is25.71%.
:exclamation: Current head ef2911a differs from pull request most recent head 5bae903. Consider uploading reports for the commit 5bae903 to get more accurate results
@@ Coverage Diff @@
## master #3918 +/- ##
===========================================
- Coverage 83.26% 72.81% -10.46%
===========================================
Files 371 56 -315
Lines 25898 4756 -21142
Branches 3975 0 -3975
===========================================
- Hits 21565 3463 -18102
+ Misses 3125 1293 -1832
+ Partials 1208 0 -1208
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@chrismytton I've been round the houses on this a bit as the mechanic I used to create this originally got broken and it was recommended that I don't use it even when it was fixed (calling 'covers' from mapit). So I've redone it pretty much. I think the original issue with the tabs not working is that you need to run ./script/setup for the scss to be compiled. I think the tab names need to be slightly different - is it District, Parish and District Ward?
I removed some variable from templates/web/base/reports/body.html which I think was superfluous too, but may be a Friday foolishness.
Been feedback on the ticket and I've made some changes regarding that.
Brief discussion here: https://mysociety.slack.com/archives/C01TK8P1K8T/p1663756092542129