fixmystreet icon indicating copy to clipboard operation
fixmystreet copied to clipboard

Increase affordance on map buttons on mobile when making a new report

Open wrightmartin opened this issue 4 years ago • 1 comments

This pull request makes a visual change to the buttons to chose the location on the map on mobile (see screenshots)

  • Increase affordance (they look like buttons now)
  • Increase visibility (the yellow presents the next action as more visible)

Before image

After image

Please check the following:

  • [x] Whether this PR should include changes to any documentation, or the FAQ;
  • [x] All cobrand-specific commits start their commit message with the cobrand in square brackets;
  • [x] Is new functionality tested? CodeCov will warn you about the diff coverage, but won’t complain about e.g. new files;
  • [x] Are the changes tested for accessibility?
  • [x] Have you updated the changelog? If this is not necessary, put square brackets around this: skip changelog

Please check the contributing docs, and describe your pull request here. Screenshots or GIF animations (using e.g. LICEcap) may be helpful.

Please include any issues that are fixed, using "fixes" or "closes" so that they are auto-closed when the PR is merged.

Thanks for contributing!

wrightmartin avatar Oct 12 '20 09:10 wrightmartin

Codecov Report

Merging #3214 (7b0b4eb) into master (89dd348) will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3214      +/-   ##
==========================================
+ Coverage   82.44%   82.45%   +0.01%     
==========================================
  Files         325      325              
  Lines       21517    21517              
  Branches     3240     3240              
==========================================
+ Hits        17739    17742       +3     
+ Misses       2739     2736       -3     
  Partials     1039     1039              
Impacted Files Coverage Δ
web/cobrands/fixmystreet-uk-councils/alloy.js 91.08% <0.00%> (+2.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89dd348...7b0b4eb. Read the comment docs.

codecov[bot] avatar Oct 12 '20 13:10 codecov[bot]