fixmystreet icon indicating copy to clipboard operation
fixmystreet copied to clipboard

Published 20 hours ago • verified publisher icon mysociety

If changing category changes the send method send_method_used is not updated.

Open struan opened this issue 4 years ago • 4 comments

If an admin changes the category of a report to one one with a different send method, e.g Open311 -> Email, then the send_method_used isn't updated. This means that any updates left on the report may be handled incorrectly.

struan avatar Sep 14 '20 12:09 struan

Is this only if disable_resend is set (so Bexley at present)? If it's not set, changing the category send method causes resend() to be called, which does reset send_method_used.

dracos avatar Oct 08 '20 10:10 dracos

No, this was related to some OCC updates.

struan avatar Oct 08 '20 10:10 struan

You'll have to provide some more detail then, as I say, it does reset send_method_used as far as I can tell?

dracos avatar Oct 08 '20 11:10 dracos

A bit of digging and one of the comments was 3944967 on report 2275901.

And yes, I'm not sure how it happened as it does look like the code should do the right thing.

struan avatar Oct 08 '20 12:10 struan