MeloTTS icon indicating copy to clipboard operation
MeloTTS copied to clipboard

可以提供一个针对特定说话人的快速finetune例子吗

Open cdmajie opened this issue 1 year ago • 3 comments

cdmajie avatar May 17 '24 02:05 cdmajie

any update here?

kleinpetr avatar Jun 10 '24 15:06 kleinpetr

I don't think we should clone the data and update the clone eagerly - it would be very inefficient and could cost extra memory. The root cause is that we didn't properly trigger the data when they updates, but also because we are dealing with multiple Vue instances (one in host, one in devtools, where watching on a forgien reactive object won't triggers properly. I think this would need a fix with another approach

antfu avatar Jun 21 '24 12:06 antfu

@antfu, I've made it possible to update only the necessary nested properties using the deepSync function. Can you check?

hichem-dahi avatar Jun 23 '24 11:06 hichem-dahi

@antfu I've removed cloning. I've used toRefs(payload.state) to reference the objects. It seems to be working.

hichem-dahi avatar Jun 26 '24 18:06 hichem-dahi

Looks great; I will test it a bit. Thanks a lot for being patient on this!

antfu avatar Jun 30 '24 12:06 antfu

I looked into it, but it seems that using toRef in template isn't a good practice. I end up with a different approach: 418a22ed624584a25eab2ed4880147e6d572eb32, which is released as v1.3.9. Please give it a try and let me know if it solves your cases. Thanks!

antfu avatar Jul 02 '24 16:07 antfu

I left a comment here. It solves the initial issue. However, when modifying from the StateEditor, the change isn't synced.

hichem-dahi avatar Jul 02 '24 20:07 hichem-dahi