NodeManager icon indicating copy to clipboard operation
NodeManager copied to clipboard

Published 20 hours ago • verified publisher icon mysensors

SensorInterrupt onLoop routine sends value

Open janjurca opened this issue 2 years ago • 1 comments

Hello I've made change that is maybe worth of discussion. The actual SensorInterrupt does send it's value only when the interrupt happens. But when the transmission fails for some reason then the value is not propagated to server not even on report interval.

So I've added the onLoop() method to SensorInterrupt.h.

janjurca avatar Sep 15 '21 09:09 janjurca

Hi! A few comments:

  • What if the transmission was successful, is a second transmission taking place anyway?
  • Any risk for non-sleeping node that loop is executed continuously?
  • Ensure the PR is against development branch not master Thanks!

user2684 avatar Sep 22 '21 10:09 user2684