NodeManager icon indicating copy to clipboard operation
NodeManager copied to clipboard

Published 20 hours ago • verified publisher icon mysensors

Fix SSD1306

Open matikij opened this issue 4 years ago • 3 comments

This simple fix works for me.

matikij avatar May 15 '20 15:05 matikij

Hi, just to double check, is this related to which issue? Is #511 (merged into development recently) still not enough? Thanks!

user2684 avatar May 18 '20 13:05 user2684

Hi, I didn't create an issue for this. It was a compile error when I was compiling for ESP8266 - then the ifdef in https://github.com/mysensors/NodeManager/blob/7fbf28aaa42d2e33736f329f152a34e91a217c3c/sensors/DisplaySSD1306.h#L136 does not hold and https://github.com/mysensors/NodeManager/blob/7fbf28aaa42d2e33736f329f152a34e91a217c3c/sensors/DisplaySSD1306.h#L139 is included, so that means that _oled field is of type SSD1306AsciiWire, which is not a SSD1306AsciiAvrI2c as expected by getDisplay() signature. SSD1306Ascii is a common and direct ancestor of both classes.

matikij avatar Jun 19 '20 14:06 matikij

Oh understand, thanks for the clarification!

user2684 avatar Jun 19 '20 15:06 user2684