MySensorsArduinoExamples icon indicating copy to clipboard operation
MySensorsArduinoExamples copied to clipboard

New Dallas temperature sensor example

Open flatsiedatsie opened this issue 7 years ago • 4 comments

After some useful feedback and co-authoring on the forum (Thanks Scalz!), the sketch is now even better.

  • Conforms better to MySensors coding standards.
  • Added option to choose sensor precision (also useful starting point for other sensors). Thanks Awi!
  • Clearer option to choose between Celsius and Fahrenheit.

Old features remain:

  • non-blocking
  • option to use sleep to preserve battery
  • Now compatible with latest OneWire and Dallas libraries
  • Lots more explanatory/educational comments, and cleaner code than before.

Forum thread: https://forum.mysensors.org/topic/6395/new-non-blocking-temperature-sensor-code/7

flatsiedatsie avatar Mar 19 '17 12:03 flatsiedatsie

Also note that you don't need to close/open new PR. You can amend the current one by pushing to the same branch. That way we keep all the comments and history related to the update in one place.

If the DallasTemperature library is no longer needed you can remove it as well.

henrikekblad avatar Mar 19 '17 20:03 henrikekblad

OK, I'll try adding it to the current request.

So.. much.. learning!

flatsiedatsie avatar Mar 23 '17 20:03 flatsiedatsie

Do I need to set this back to "please review" somehow?

flatsiedatsie avatar Apr 14 '17 08:04 flatsiedatsie

Could we perhaps make a new example with your changes? I.e. DallasTemperatureSensorNoneBlocking.ino (or shorter if you can come up with a nifty name ;) )

I'd like to keep the current one as simple as possible.

henrikekblad avatar May 10 '18 21:05 henrikekblad