MySensors icon indicating copy to clipboard operation
MySensors copied to clipboard

Fix compilation of RFM69_new driver on aarch64 architecture

Open docbender opened this issue 3 years ago • 1 comments

docbender avatar Aug 19 '21 14:08 docbender

Sorry for the slow response.

@docbender could you share your thinking around the removed and commented debug lines?

mfalkvidd avatar Sep 16 '22 21:09 mfalkvidd

Just to confirm that to build on arm64 this small part of this PR is required:

diff --git a/hal/transport/RFM69/driver/new/RFM69_new.h b/hal/transport/RFM69/driver/new/RFM69_new.h
index 9384b50c..35cb0810 100644
--- a/hal/transport/RFM69/driver/new/RFM69_new.h
+++ b/hal/transport/RFM69/driver/new/RFM69_new.h
@@ -127,7 +127,7 @@
 #endif
 
 #define RFM69_FIFO_SIZE                  (0xFFu)               //!< Max number of bytes the Rx/Tx FIFO can hold
-#define RFM69_MAX_PACKET_LEN             (0x40u)               //!< This is the maximum number of bytes that can be carried 
+#define RFM69_MAX_PACKET_LEN             static_cast<size_t>(0x40u)    //!< This is the maximum number of bytes that can be carried
 #define RFM69_ATC_TARGET_RANGE_DBM       (2u)                          //!< ATC target range +/- dBm
 #define RFM69_PACKET_HEADER_VERSION      (1u)                          //!< RFM69 packet header version
 #define RFM69_MIN_PACKET_HEADER_VERSION  (1u)                          //!< Minimal RFM69 packet header version

Tested on Armbian NanoPi Neo3 jammy current 6.1.30 image and FriendlyElec NanoPi Neo3 device with RFM69 radio.

paukstis avatar Aug 07 '23 09:08 paukstis