MySensors icon indicating copy to clipboard operation
MySensors copied to clipboard

Published 20 hours ago • verified publisher icon mysensors

Auto id mode in RS485 transport doesn't work

Open klaudiusz223 opened this issue 4 years ago • 1 comments

Automatic ID assignment doesn't work for RS485 transport. As mentioned in this post https://forum.mysensors.org/topic/4854/building-a-wired-rs485-sensor-network/23 . The problem is caused by:

  • setting sender id to 0 instead of 255 in RS485 transport header when node doesn't have assigned ID
  • wrong packet filtering in the RS485 transport header and discarding broadcast packets from nodes without assigned ID https://github.com/mysensors/MySensors/blob/8f1f8ad2415034569a77d99f6ed9c02573c71418/hal/transport/RS485/MyTransportRS485.cpp#L149 https://github.com/mysensors/MySensors/blob/8f1f8ad2415034569a77d99f6ed9c02573c71418/hal/transport/RS485/MyTransportRS485.cpp#L168-L176

klaudiusz223 avatar Nov 10 '20 11:11 klaudiusz223

Is this pull request (#1451) going to be merged any time soon?

feanor-anglin avatar Oct 09 '21 11:10 feanor-anglin