Jonathan-David Schröder
Jonathan-David Schröder
@markshust Thanks for that patching! Those lines should ideally be run before the composer create-project downloading call in the `bin/download` script: https://github.com/markshust/docker-magento/blob/f81cfc4d35574a4a7eb0aa61a9cb94fe0e2a450d/compose/bin/download#L24 while you have put them in the `bin/setup`...
Just proposed a PR will the 3 lines located in `bin/download` instead before the `composer create-project` line #741 seems to a duplicate of this. Asked submitter to try out that...
@markshust The PR needs your approval to run Github Actions tests
@hostep Thank you, [I improved the PR ](https://github.com/markshust/docker-magento/pull/742/files) with your 3-steps suggestion (composer create project with no-install flag, add 3 allowances for magento-related dependencies, composer install fully) We could either...
To me the PR is OK, tested manually locally (using the github CLI tool named `gh`) without the >= 2.3.7 to < 2.4.4 filter yet: ``` gh repo clone markshust/docker-magento...
Apologies, I just added a `cd` line after the `gh clone` to fix your first error.. (in the above comment)
You should stop your previously created running docker images between attempts (so, basically now) with: `bin/stopall` Also each new attempt would need a new directory.. So: ` gh repo clone...
@hostep I added version filtering to the PR as you recommended. Needs testing.
This is a duplicate of #731 I recommend you try running a current PR patch for the onlinesetup script and bin/download set: `curl -s https://raw.githubusercontent.com/markshust/docker-magento/6a2fb7e0cc3d959ce7d5a383a27197ba48687d62/lib/onelinesetup | bash -s -- magento.test...
Sorry my advised command is wrong.. it will continue pulling the master branch's bin/install script instead of the pull request's one