mylinuxforwork
Remove firefox/nautilus from mandatory packages + use options.sh to install browser/filemanager post-install
Instead of installing firefox & nautilus and setting them as defaults, this change will make it so the browser & file manager can be chosen by the user after installation of ML4W. This accounts for users that may already have browsers installed that they want to use, or those who do not wish to use a browser at all.
Instead of adding extra files/bloat to the codebase, this solution uses a slightly modified version of options.sh to allow targeted installs of additional packages without going through the initial menu
Changes made:
- Allow directly passing which package to modify for nl4w-options
- Removes firefox & nautilus from default packages
- Edited browser.sh and filemanager.sh to point to nl4w-options with the additional parameter by default
- Changes to all options files to ensure backwards compatibility
- Modified the waybar links, changed firefox icon to universal "web" icon
Is there a way to retain firefox icon on waybar if the web browser is firefox? I really like my firefox icon and would pain me if I had to hack together a replace string script in post.sh
Is there a way to retain firefox icon on waybar if the web browser is firefox? I really like my firefox icon and would pain me if I had to hack together a replace string script in post.sh
Can definitely be done, i'll replace the default browser icon with the firefox icon if it is the chosen option in the options wizard.
@ArekKubinski This will now automatically update both the tooltip and icon whenever the browser is switched via ML4W options. (Currently the default font seems to only support firefox and chrome icons though)
@redsh4de With the latest push, firefox and nautilus will be only installed with an initial installation. I will look into your improvements.
@mylinuxforwork Sounds good!
Regarding the 'unorthodox' way the icon/name are replaced in waybar-quicklinks.json - i did plan to use jq initially, but it doesn't support the json5/hjson syntax with comments, so using a combo of common gnu utils was the best alternative so that no additional packages need to be installed
@redsh4de Thanks for your updates. I have just pushed an more readable version of the quicklinks.json to the main branch.
I will look into your options updates later after the release of 2.9.8
@mylinuxforwork Gotcha! Yea the script will still work all the same, as it would look for the parent JSON object containing browser.sh
I also noticed that now email is included in the waybar, so i added e-mail installation options to the options.sh script + packages for both arch and fedora
@mylinuxforwork I believe this pull request is ready to be merged as it appears clean and serves its purpose, but that's just my take on it. Ultimately, the decision is yours.
@redsh4de Not able to test it before the release of 2.9.8.0 I will check again for 2.9.8.1. Hope that's Ok for you.
@mylinuxforwork This should now be up to date with the changes made since the previous releases