dotfiles icon indicating copy to clipboard operation
dotfiles copied to clipboard

[FEATURE] Keybinding help window takes a little long time to pop up. (Isn't blazingly fast/smooth)

Open arkochan opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe. I'm always frustrated when keybinding help window takes a long time (atleast more than a second) to pop up. This is due to the fact that each time hypr/scripts/keybindings.sh is called the whole .conf file is read to auto generate the keybinds variable which is later used as an input redirection to launch a rofi window for the list.

Describe the solution you'd like Rather than generating the keybinds variable from the keybind .conf (eg. hypr/keybindings/default.conf) file each time hypr/scripts/keybindings.sh script is ran, it can be generated once after each modification. It can be done in this process:

  1. check if a generated help file already exists for the selected keybind .conf file.
  2. if not: generate a file from the keybinds variable.
  3. else: use already generated help file

To ensure for each modification a single file is generated if can be checked either using the last modification using stat -c '%Y' $config_file or by generating a hash value for the file.

Additional context Only the while loop to read default.conf file in hypr/scripts/keybindings.sh takes about ~820 milliseconds on my machine. This is apart from the time taken by rofi to start after the 0.2s sleep. Which sums up to about a couple of seconds sometimes. Meanwhile there is no confirmation whether I've hit the right keybind for the keybind help or not.

arkochan avatar Nov 05 '24 05:11 arkochan

@arkochan Thanks for bringing this issue up and your detailed explanation. I will check how to implement your proposal for the upcoming version 2.9.7

mylinuxforwork avatar Nov 05 '24 16:11 mylinuxforwork