Potential get_most_recent_status_id problem with bookmarks and favourites.

[oscherler]

I think there’s a small mistake here:

https://github.com/myles/mastodon-to-sqlite/blob/be1db4c31fe393f96062298cd63111f5e7299bc2/mastodon_to_sqlite/service.py#L314-L323

Indeed, this method is used to download your posts that are more recent than the most recent post already in the database. But since favourites and bookmarks are saved in the same table, it means that if I do this:

1. Download statuses and bookmarks;
2. Wait a week;
3. Bookmark a recent post;
4. Download bookmarks;

then if I try and update statuses, the most recent status ID will be the one of the bookmark I just saved, instead of the ID of the last of my own posts we downloaded.

I’m working on a better way to update the database, so it might not be an issue once I’m done, but in the meantime, I thought I’d document it here, in case someone happens to have trouble with this.