Paul Jolly

Results 612 comments of Paul Jolly

> Basically what this PR does is to remove SrcModTime? Currently staleness of an archive is determined using mod time of the transitive set of input files, the gopherjs binary...

Thanks for taking a look @hajimehoshi - addressed your feedback. PTAL.

@hajimehoshi - I've tweaked a couple of things in my latest commit which also addresses the points you made. I've also moved from `gopherjs binary hash` to `compiler binary hash`...

@hajimehoshi thanks for taking a look. I've responded to your questions and removed the `--bv` flag for `gopherjs test`.

Hi @shurcooL - very happy to add more detail. I pushed up the code to help with our discussion. What follows is based on my understanding of how archive staleness...

I've also just added a basic test to show this in action and working.

Got hit by another staleness bug again this afternoon. Still unclear how the situation with mod times getting out of sync comes about, but the hash-based approach has been 100%...

@paralin > ... the output of gopher... I think you'll find everyone refers to "it" as GopherJS, but that's a minor point :) > Everything still works ok doing this...

@paralin > I can understand if you don't want to delegate this task to an external tool, though. Just to clarify, I'm speaking on my own behalf as an interested...

@theclapp there's two issues/bugs here that are related. It appears that fields of embedded structs are not being correctly transpiled. Given: ```go package main import ( "github.com/gopherjs/gopherjs/js" ) type T1...