language-check icon indicating copy to clipboard operation
language-check copied to clipboard

can't install from the git repo with OpenJDK

Open jeanbaptisteb opened this issue 6 years ago • 5 comments

Config:

  • Ubuntu Server 18.04 "Bionic Beaver" LTS (64bits)
  • Python 3.6.5,
  • openjdk 10.0.1 2018-04-17
  • OpenJDK Runtime Environment (build 10.0.1+10-Ubuntu-3ubuntu1)
  • OpenJDK 64-Bit Server VM (build 10.0.1+10-Ubuntu-3ubuntu1, mixed mode)

I tried to install language-check from pip, and the installation works. But then, when I try using it in some Python code, it throws some error.

So I tried to install language-check directly from the git repo, as suggested in another issue, with: pip3 install git+https://github.com/myint/language-check.git But then I get:

Could not parse Java version from """openjdk version "10.0.1" 2018-04-17 OpenJDK Runtime Environment (build 10.0.1+10-Ubuntu-3ubuntu1) OpenJDK 64-Bit Server VM (build 10.0.1+10-Ubuntu-3ubuntu1, mixed mode

I also tried installing it on Windows, with the following configuration, and in this case it works like a charm:

  • Windows 10, 64 bits,
  • Python 3.6.3
  • java version "1.8.0_171"
  • Java(TM) SE Runtime Environment (build 1.8.0_171-b11)
  • Java HotSpot(TM) 64-Bit Server VM (build 25.171-b11, mixed mode)

So I guess that the problem comes from OpenJDK on Ubuntu.

Any advice?

jeanbaptisteb avatar Jul 09 '18 21:07 jeanbaptisteb

Same issue here with the 18.04 ubuntu desktop image. Got this error message:

Running setup.py bdist_wheel for language-check ... error

  Complete output from command /home/bag_of_words/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-w08w5t2o/language-check/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" bdist_wheel -d /tmp/pip-wheel-wap2l03f --python-tag cp36:
  Could not parse Java version from """openjdk version "10.0.1" 2018-04-17
  OpenJDK Runtime Environment (build 10.0.1+10-Ubuntu-3ubuntu1)
  OpenJDK 64-Bit Server VM (build 10.0.1+10-Ubuntu-3ubuntu1, mixed mode)

Bachstelze avatar Jul 15 '18 20:07 Bachstelze

Hmm, it seems to be a duplicate of https://github.com/myint/language-check/issues/31, isn't it?

jeanbaptisteb avatar Jul 16 '18 12:07 jeanbaptisteb

Yes, should be a duplication because they also can not parse the java version with this regex, but it is not failing with only one certain java version. You can try my Pull-request or delete on your own 3 characters :D #56

Bachstelze avatar Jul 17 '18 20:07 Bachstelze

This should be fixed with https://github.com/myint/language-check/pull/57 Can we make a new release for pip with this bug fix?

Bachstelze avatar Aug 13 '19 08:08 Bachstelze

Hi! Since this project has been abandoned, I started a new fork over at https://github.com/jxmorris12/language_tool_python.

My version supports new versions of Java and LanguageTool. language-check is stuck on Java 8 and LanguageTool 3.2; latest versions are Java 14 and LanguageTool 4.9!

I'm happy to help you with your issue if you raise it over at my repository! Thanks!

jxmorris12 avatar May 01 '20 03:05 jxmorris12