Francesco Gringl-Novy

Results 420 comments of Francesco Gringl-Novy

Hmm, no clue why this is failing - I don't believe it was caused by this PR?

Yes, so if you want to mutate the breadcrumb sent to sentry it has to be sync, as of now. Because we just continue after the hook is fired, there...

Hey @scttcper do you mind resolving merge conflicts (rebasing on develop), then I'll take a look - thank you! (and sorry for late response, got a bit lost there...)

> Hi, I am interesting in this replay and in the error mode. I am looking the different resources and it is quite a lot to get a full understanding....

Thanks for the explanation! Yeah, I think I see what you mean. We'll take this into consideration with our planning. Priority here is work to ensure we capture at least...

> Thanks for the PR! > > A concern I have is that bumping the major version of Sentry means introducing a breaking change. It's only a small one and...

We don't have a full lambda example right now, but it would be great to have one - PRs are welcome to our examples repo! We have an example for...

Hey, just to clarify: Are you using `withSentryRouting` as described here: https://docs.sentry.io/platforms/javascript/guides/react/features/react-router/#parameterized-transaction-names without this, you wouldn't get parametrized routes.

Thanks for bearing with us! I identified the problem and have a fix up here: https://github.com/getsentry/sentry-javascript/pull/11855

> @mydea thanks for the quick fix, wondering if this will also be included with V8? Yes, it will be in the next release - most likely we'll cut v8.0.0-beta.6...