Francesco Gringl-Novy

Results 428 comments of Francesco Gringl-Novy

I added some more code comments based on @BYK's comments, to make it (hopefully) easier to follow what the exporter does! 🙏

It was actually a great pointer from @BYK that we should really actually profile/measure if the for loop is faster than the flatMap, instead of just assuming so. I ran...

Updated this based on feedback in regard to scopeclient relationship. Now, a scope holds a reference to a client, which can be set via `scope.setClient()`. The client is inherited by...

> Left some questions / comments. Generally I'm surprised to see such a focus on client and its APIs. In Java SDK these are rarely touched by clients and rather...

> > make the client internal/private > > There are users who customize clients, e.g. to support multi DSN or send events somewhere else as well. While rare this is...

I applied all the feedback and moved this out of draft - I think this is ready to "really" review!

> From RN point of view I don't we can merge Hub and Scope. 99% time users can use `Sentry.captureException` static API, the same as in browser JS. > >...

After talking about this with @mitsuhiko , I updated this RFC to again include the (updated) concepts of a global scope, as well as an isolation scope. The idea is...

> After these changes, spotlight will always be included in production bundles and release/environment/etc will automatically be pulled from environment variables at runtime which we don't want. Ah, valid points!...

Hey, I've transferred this issue to the sentry-electron repo. @timfish could you take a look?