whisper.rn icon indicating copy to clipboard operation
whisper.rn copied to clipboard

Unable to stop transcription on 0.4.0

Open EightPool opened this issue 5 months ago • 4 comments

I was testing the latest RC version and noticed that the stop method is broken on iOS since 0.4.0-rc.5. Also, it appears that the stop method issue on Android has not been resolved with #143.

Is there a new method to abort the transcription of a file instead of using stop() ?

EightPool avatar Jan 09 '24 01:01 EightPool

Fixed in 1421c55 and d1541ae.

jhen0409 avatar Jan 17 '24 03:01 jhen0409

Hello, after trying v4.0.0-rc.7, it appears that transcription still cannot be stopped.

sdip15fa avatar Jan 18 '24 15:01 sdip15fa

Due to recent whisper.cpp changes, the abort callback is not used in ggml_graph_compute_helper anymore. The abort_callback only used in whisper_encode_internal / whisper_decode_internal now.

I'll look at the reasons for this change later.

jhen0409 avatar Jan 19 '24 02:01 jhen0409

@jhen0409 Do you have any update on this? Just tried out the newest RC and having the gpu optional available is incredibly great. Sadly this issue is a real blocker for a full 4.0 release.

Any help needed from the community? If so it would be nice to have a few extra pointers on this.

Thanks for all the work on this great library.

jobpaardekooper avatar Mar 13 '24 16:03 jobpaardekooper