mybb icon indicating copy to clipboard operation
mybb copied to clipboard

User CP input validation - move to datahandler

Open euantorano opened this issue 4 years ago • 6 comments

The user CP do_profile action has some validation done in usercp.php that then uses error(). This validation should be moved to the user data handler:

euantorano avatar May 28 '20 12:05 euantorano

I'll take a look at creating a PR for this to go into 1.8.24.

Ben-MyBB avatar May 28 '20 12:05 Ben-MyBB

Hmm, just found out that these input fields also exist in ModCP but don't have validations. So #4014 isn't enough, and moving the validations to user handler should benefit both UserCP and ModCP, and probably AdminCP..

yuliu avatar Jun 17 '20 06:06 yuliu

Just a note to put here, I am willing to implement a date validation function affecting all date inputs in MyBB. Currently MyBB accepts impossible dates like 31-2-2020 (d-m-Y)

effone avatar Feb 02 '21 11:02 effone

@Ben-MyBB - are you willing to continue with this?

Eldenroot avatar Feb 24 '21 20:02 Eldenroot

@Eldenroot I probably don't have the time to continue this one for now so I've unassigned myself, feel free to complete if you wish.

Ben-MyBB avatar Feb 24 '21 21:02 Ben-MyBB