Translated to Traditional Chinese

[doggy8088]

[sheraium]

LGTM

[harawata]

Did you guys verify the result of mvn clean site? I don't see a directory for zh_TW in target/site.

[doggy8088]

@harawata Is there any translation guideline? I don't know how to do it right.

Should I modify pom.xml file for new language?

[doggy8088]

I added. There is still no zh-tw appear in target/site folder after run mvn site.

Here is my folder structure:

The log shown:

It seems look for zh which is wrong. I don't know how to do it right.

[doggy8088]

I tried so many ways to generate zh_TW locale for the site. Still failed. Anyone can help? :(

[doggy8088]

I think this issue is caused by Apache Maven Site Plugin. I created a bug report here: https://issues.apache.org/jira/browse/MSITE-904

[awxiaoxian2020]

It seems we could work on this issue now.

[doggy8088]

@awxiaoxian2020 Are you able to support different zh locale now?

[awxiaoxian2020]

I just notice that we have moved maven site 4.

[doggy8088]

So I should send another PR, right?

[awxiaoxian2020]

You can just resolve the conflict I think.

[doggy8088]

@awxiaoxian2020 I'm struggling with the build process. I tried to build mybatis-3 project in the docker container:

docker run -it --rm --name=mybatis maven:3-eclipse-temurin-11 bash

I git clone the repo and checkout the master branch. Then I run the following commands. (Reference from your GitHub Actions)

git clone https://github.com/mybatis/mybatis-3.git --depth=1
cd mybatis-3

ARG_LINE=-D"argLine=--illegal-access=permit"
./mvnw test -B -V  --no-transfer-progress -D"license.skip=true" -D"jacoco.skip=true" $ARG_LINE

./mvnw help:active-profiles
./mvnw site site:stage -DskipTests -B -V --no-transfer-progress -Dlicense.skip=true

Then I'll get the following errors:

5 errors
40 warnings
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:06 min
[INFO] Finished at: 2024-02-24T17:23:01Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:4.0.0-M13:site (default-site) on project mybatis: Error generating maven-javadoc-plugin:3.6.3:javadoc report:
[ERROR] Exit code: 1
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/annotations/Select.java:28: error: self-closing element not allowed
[ERROR]  * <b>How to use:</b> <br/>
[ERROR]                       ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/annotations/Select.java:44: error: bad use of '>'
[ERROR]  *   &#064;Select({ "&lt;script>", "select * from users", "where name = #{name}",
[ERROR]                                ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/annotations/Select.java:45: error: bad use of '>'
[ERROR]  *       "&lt;if test=\"age != null\"> age = #{age} &lt;/if>", "&lt;/script>" })
[ERROR]                                      ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/annotations/Select.java:45: error: bad use of '>'
[ERROR]  *       "&lt;if test=\"age != null\"> age = #{age} &lt;/if>", "&lt;/script>" })
[ERROR]                                                            ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/annotations/Select.java:45: error: bad use of '>'
[ERROR]  *       "&lt;if test=\"age != null\"> age = #{age} &lt;/if>", "&lt;/script>" })
[ERROR]                                                                            ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/builder/MapperBuilderAssistant.java:271: warning: no @param for resultSets
[ERROR]   public MappedStatement addMappedStatement(String id, SqlSource sqlSource, StatementType statementType,
[ERROR]                          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/session/Configuration.java:844: warning: no @return
[ERROR]   public Collection<XMLStatementBuilder> getIncompleteStatements() {
[ERROR]                                          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/session/Configuration.java:861: warning: no @return
[ERROR]   public Collection<CacheRefResolver> getIncompleteCacheRefs() {
[ERROR]                                       ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/session/Configuration.java:878: warning: no @return
[ERROR]   public Collection<ResultMapResolver> getIncompleteResultMaps() {
[ERROR]                                        ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/session/Configuration.java:904: warning: no @return
[ERROR]   public Collection<MethodResolver> getIncompleteMethods() {
[ERROR]                                     ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:46: warning: no @param for expression
[ERROR]   public Iterable<?> evaluateIterable(String expression, Object parameterObject) {
[ERROR]                      ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:46: warning: no @param for parameterObject
[ERROR]   public Iterable<?> evaluateIterable(String expression, Object parameterObject) {
[ERROR]                      ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:46: warning: no @return
[ERROR]   public Iterable<?> evaluateIterable(String expression, Object parameterObject) {
[ERROR]                      ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:53: warning: no @param for expression
[ERROR]   public Iterable<?> evaluateIterable(String expression, Object parameterObject, boolean nullable) {
[ERROR]                      ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:53: warning: no @param for parameterObject
[ERROR]   public Iterable<?> evaluateIterable(String expression, Object parameterObject, boolean nullable) {
[ERROR]                      ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:53: warning: no @param for nullable
[ERROR]   public Iterable<?> evaluateIterable(String expression, Object parameterObject, boolean nullable) {
[ERROR]                      ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:53: warning: no @return
[ERROR]   public Iterable<?> evaluateIterable(String expression, Object parameterObject, boolean nullable) {
[ERROR]                      ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for configuration
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for contents
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for collectionExpression
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for index
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for item
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for open
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for close
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for separator
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for configuration
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for contents
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for collectionExpression
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for nullable
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for index
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for item
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for open
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for close
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for separator
[ERROR]   public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR]          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:31: warning: no @param for <K>
[ERROR]   public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
[ERROR]                          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:31: warning: no @param for <V>
[ERROR]   public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
[ERROR]                          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:31: warning: no @param for map
[ERROR]   public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
[ERROR]                          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:31: warning: no @param for key
[ERROR]   public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
[ERROR]                          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:31: warning: no @param for mappingFunction
[ERROR]   public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
[ERROR]                          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:31: warning: no @return
[ERROR]   public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
[ERROR]                          ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:42: warning: no @param for <K>
[ERROR]   public static <K, V> Entry<K, V> entry(K key, V value) {
[ERROR]                                    ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:42: warning: no @param for <V>
[ERROR]   public static <K, V> Entry<K, V> entry(K key, V value) {
[ERROR]                                    ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:42: warning: no @param for key
[ERROR]   public static <K, V> Entry<K, V> entry(K key, V value) {
[ERROR]                                    ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:42: warning: no @param for value
[ERROR]   public static <K, V> Entry<K, V> entry(K key, V value) {
[ERROR]                                    ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:42: warning: no @return
[ERROR]   public static <K, V> Entry<K, V> entry(K key, V value) {
[ERROR]                                    ^
[ERROR] Command line was: /opt/java/openjdk/bin/javadoc @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in '/mybatis-3/target/site/apidocs' dir.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

Do you know how to fix it?

[hazendaz]

@doggy8088 Javadocs are rather misleading. Ignore the [error] on left as its hiding real issue. Instead look at the right hand side. Bulk of those are warnings which is ok. There is an error on the right though that does need fixed.

Also if you could fix your merge conflicts while at it.

[doggy8088]

I just want to make sure I can build this project before I contribute translations.

Why you haven't met this issue?

[hazendaz]

Your branch is conflicted, its failing because its conflicted. Try fixing your conflicts and try again.

[doggy8088]

@hazendaz I know it's conflicting. I'm not building my branch. I'm building master branch. I want to build it before I fix the conflicts.

[hazendaz]

Master builds fine against the following https://github.com/mybatis/mybatis-3/blob/master/.github/workflows/ci.yaml, what problem are you having exactly? jdk 11 is required at a minimum to build. The item mentioned above from you earlier I presume was this build. However, I see you changed no source so that is odd. Its a javadoc issue. Its clear what it is there but its not failing on our master. If you have some time, take a look at what you are seeing there and if really issue on our end, please send a PR to fix. It looks trivial but unclear to me at the moment why you would see that but we don't.

[hazendaz]

It is during site so it could be related to this change, are you saying master is doing that from the site?