scrapydweb
scrapydweb copied to clipboard
pymysql versioning check does not work for versions above 0.10.*
Describe the bug Current logic to check version of pymysql throws assertion error for newer version 0.10.* and above
To Reproduce Steps to reproduce the behavior:
- Install newest version of pymysql
- run scrapydweb
- Assertion error appears
Expected behavior Newer versions of pymysql should not throw the error
Logs
Run command: pip install --upgrade pymysql
Additional context
Potential solution - just change simplistic string comparison of version on line 94
in setup_databases.py
to something more sophisticated.