scrapydweb icon indicating copy to clipboard operation
scrapydweb copied to clipboard

pymysql versioning check does not work for versions above 0.10.*

Open sergiigladchuk opened this issue 4 years ago • 0 comments

Describe the bug Current logic to check version of pymysql throws assertion error for newer version 0.10.* and above

To Reproduce Steps to reproduce the behavior:

  1. Install newest version of pymysql
  2. run scrapydweb
  3. Assertion error appears

Expected behavior Newer versions of pymysql should not throw the error

Logs

Run command: pip install --upgrade pymysql

Additional context Potential solution - just change simplistic string comparison of version on line 94 in setup_databases.py to something more sophisticated.

sergiigladchuk avatar Jul 28 '20 12:07 sergiigladchuk