jasmine.async icon indicating copy to clipboard operation
jasmine.async copied to clipboard

Add timeout argument for async

Open dat-boris opened this issue 12 years ago • 7 comments

A simple change to allow timeout parameter to be passed to feature implemented in:

https://github.com/mhevery/jasmine-node/pull/142

Please do let me know if there's any feedback.

Thanks for this great snippet that make life easier for async test.

dat-boris avatar Jan 09 '13 19:01 dat-boris

This actually resolves an issue we discussed today where we needed a test to wait longer (due to various conditions). Granted, having to design for this reveals a larger flaw, but when pinned and need a solution ... well it's convention with configuration like this request that helps

johntimothybailey avatar Jan 24 '13 09:01 johntimothybailey

Just applied it to our test-suite. We have tests that take up to 10 seconds in older firefox-versions (we have to support). This made our tests work again on the build-server.

ChristophGr avatar Apr 22 '13 12:04 ChristophGr

Seriously, this pull request deserves some attention. Would make some awesome code even awesomer.

traviswimer avatar Jul 16 '13 19:07 traviswimer

+1

theladyjaye avatar Jul 07 '14 12:07 theladyjaye

bump

antialias avatar Aug 12 '16 20:08 antialias

at this point, i don't plan to maintain this code repo. jasmine v2.x has this feature built in without needing an additional library. if someone is still working with jasmine v1.0 and wants to maintain this library, let me know and i'll transfer ownership of this library to you

mxriverlynn avatar Aug 16 '16 17:08 mxriverlynn

@derickbailey understood, but if it's any motivation to you to continue work on this feature, it doesn't look like it exists in Jasmine 2 docs. If a timeout for a specific spec is desired, they recommend storing the old timeout value, setting it, then resetting it after the spec:

http://jasmine.github.io/2.0/introduction.html#section-44

antialias avatar Aug 16 '16 18:08 antialias