Dezső BICZÓ
Dezső BICZÓ
I do not see this working, can somebody confirm and maybe share the setup that s/he is using? I am using Chrome driver in a container, maybe that is the...
Okay, so it is working with the https://gitlab.com/DMore/chrome-mink-driver after my patch is applied https://gitlab.com/DMore/chrome-mink-driver/-/merge_requests/79
Is it? Don't we just need to analyze implementation of `\Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()` and identify if they added any new service definition without marking it public? (Just thinking aloud)
#271 was the issue when the message was redirected to stderr.
How about just relying on the built-in solution by PHPStan? https://phpstan.org/user-guide/ignoring-errors Or anybody who really need go "rogue" can create their own ruleset without depending on the those that comes...
Leaving this here as a reference, IIRC we talked about this on Twitter; adding something similar as a solution here: https://github.com/phpstan/phpstan-strict-rules/commit/f120c3b73e01e9330c8a0cfc408f0c3f94ac6a89
My other idea was using environment variables for this so the list could be extended by the runtime environment (like Docker) easily.
Well, we switch the way we test modules in isolation, so currently it is not a blocker, but probably still a good idea making this configurable, extendible.
Let's start possible key components for this here: https://github.com/symplify/twig-phpstan-compiler
But it could... :-) How about merging this instead? 🙏 https://www.drupal.org/project/drupal/issues/3110266