mx
mx
> I'm happy to do that for clarity. I actually already had that work done because I needed it for my custom fixture definition in QLC+ (Also happy to provide...
@blazoncek thank you for the review. I pushed changes that shall resolve your comments as suggested (hopefully).
Question: There is also a 3rd color for segments. Maybe 3rd RGBW would also be good to add to these `Effect` control modes, what do you think? I already missed...
- The code now uses setter methods as @blazoncek mentioned (except effect _speed_ & _intensity_ - I couldn't find). - Added missing `effect option` DMX channel (_mirror_ & _reverse_) -...
Beta test request: https://wled.discourse.group/t/dmx-effect-mode-refactoring-beta-testing/6498
No, there is no realtime RGB segment control in this PR. Only `Effect` mode refactoring as in description.
> Can you confirm that the DMX receiver code from the sparkfun driver is not needed, and will not be needed for the changes you are working on? As you...
Beta tested successful: https://wled.discourse.group/t/dmx-effect-mode-refactoring-beta-testing/6498/29?u=mxklb
Is there anything missing or I can do?
It's tested by myself && in https://wled.discourse.group/t/dmx-effect-mode-refactoring-beta-testing As far as we haven't missed something, it's working exactly as described above. IMO it's save to merge ..