react-native-material-menu icon indicating copy to clipboard operation
react-native-material-menu copied to clipboard

fixing modal not hiding because of the animation

Open nicolaslazzos opened this issue 4 years ago • 4 comments

On the hide() method, when the menuState is being setted as HIDDEN, this was triggering the _onMenuLayout() method, so the menuState was immediately being setted to ANIMATING, which was causing the modalVisible variable to be true. So, though this was an unwanted behavior, in mobile it wasn't showing, but in web, because of the modal wasn't closing, it stayed and forced you to click on the screen again so that it closed after the menu disappeared.

I simply added that when the menuState is HIDDEN, the _onMenuLayout() method ignores that trigger.

nicolaslazzos avatar Mar 05 '21 22:03 nicolaslazzos

Is there any workaround for this issue for v1.2.0 + Expo SDK42? I am facing issues getting v2.0.0 to start with Expo SDK 42 to will need to stick to v1.2.0 till the other issue gets resolved.

gpsolarco avatar Aug 26 '21 03:08 gpsolarco

@gpsolarco you got this issue on mobile?

mxck avatar Aug 26 '21 07:08 mxck

Both Mobile and Web. My current RN code base is still class based but that should not be an issue I think.

gpsolarco avatar Aug 27 '21 00:08 gpsolarco

Any update on this issue? thanks!

gpsolarco avatar Oct 01 '21 03:10 gpsolarco