nacp icon indicating copy to clipboard operation
nacp copied to clipboard
verified publisher icon mxab

Accessing UI with unauthenticated and/or expired token lead to a crash

Open ncode opened this issue 9 months ago • 2 comments

Accessing Nomad via nacp with resolve token enabled will lead to a crash since we pass and empty pointer to applogger, so now we will only try to log if a token is render regardless if enabled or not.

The second part is to change to only log when a token resolution fail, so avoid use popups like the attached image shows

image (5)

ncode avatar Mar 19 '25 15:03 ncode

@mxab I will leave as a draft until I find all the corner cases :)

ncode avatar Apr 11 '25 12:04 ncode

We've been running with this patch since last week and found no more issues. So I'm happy with it now.

ncode avatar Apr 14 '25 07:04 ncode

Hi @ncode really sorry for picking this up now, I was in the middle of the otel stuff and just had the time to review and reproduce it now.

I'm currently trying to setup a test for it now an wondering if we should either "ignore" the resolving error like you do it or actually check if is one of the actionable calls i.e. registry, plan or validate and only do then the resolving?

mxab avatar Sep 30 '25 21:09 mxab

I hope you don't might that I'm closing this PR as I think the way where we handle only relevant requests is more suitable #49

mxab avatar Oct 03 '25 09:10 mxab