Mauricio Aviles

Results 31 comments of Mauricio Aviles

I agree the repeat wording in the namespace is not ideal, but consumers of the library will most likely not use the fully qualified name when instantiating classes, so they...

Yes, sending it over the wire. This is specially relevant in the world of micro-services. Where component A may be consuming content from component B, who in turn may receive...

I like the update in PR #121 -- exceptions now give us access to the list of errors thrown by Fitbit (although I still think that the multiple errors per...

It is my understanding that all [API request errors](https://dev.fitbit.com/docs/oauth2/#api-request-errors) will have a `HttpStatusCode` other than 200. Hence, I believe it would be very valuable to surface this information through the...

Moving this discussion for Post V2.0 as we do not see us implementing the `HttpStatusCode` before then. This can be a backward compatible change and therefore part of a 2.X...

I see the difference now. Example: Old subscription url: "https://api.fitbit.com/1/user/-/activities/apiSubscriptions/X1Y2Z3-activities.json" -- [source](http://web.archive.org/web/20150907232037/https://dev.fitbit.com/docs/subscriptions/) New subscription url: "https://api.fitbit.com/1/user/-/activities/apiSubscriptions/X1Y2Z3.json" -- [source](https://dev.fitbit.com/docs/subscriptions/)

@WestDiscGolf This was your feedback. Since you know exactly what needs to be done, can you take a stab at it?

Moving to stable. If you can get us a PR tonight we will include it with RC ;)

Shell implementation is in. I think this can be more efficiently fixed by @aarondcoleman since he has full background.

Did we ever come to an agreement on this?