mwyrzykowski

Results 197 comments of mwyrzykowski

Perhaps I forget the discussion but why do we need `binding_array` instead of using the existing `array` for this feature?

> * `inheritBuffers` probably includes argument buffers, uniform/storage buffers, vertex, and index buffers but this needs to be verified. Yes that is correct. It also includes textures and samplers. >...

> > Yes that is correct. It also includes textures and samplers. > > Only if they're referenced via argument buffer? Or all textures/samplers (via setTexture etc)? The setTexture:/setSampler: calls...

There is also the additional concern here, perhaps making this unimplementable on Metal, that bind groups could not be set during render bundle encoding when `inheritBuffers=YES`. Doing so results in...

> Aha, that answers my questions above about "exporting". So we would have a single boolean toggle between "use only local bind groups" and "use only inherited bind groups". It...

So how this would work with Metal ICBs is something like this: Make a vertex or compute shader like: ``` struct ICBContainer { command_buffer commandBuffer; }; [[vertex]] void rewriteBindGroups(device ICBContainer...

> I'm partial to 3, but I'd like to hear if anyone is concerned about implementation viability. Option (3) seems pretty reasonable, it would only require size checks on executeBundles...

> [@mwyrzykowski](https://github.com/mwyrzykowski) have you tried the snippet of code for ICB generation in [#5171 (comment)](https://github.com/gpuweb/gpuweb/issues/5171#issuecomment-2842872228) works in practice? It looks like it would require the GPU to do a vertex...

Indeed this is a WebKit bug, it is fixed with https://bugs.webkit.org/show_bug.cgi?id=276722 which can be verified in the next build or two of Safari Technology preview as the issue reproduces on...

Yes it should be resolved in Safari Technology Preview 202 and later