handlebars.scala icon indicating copy to clipboard operation
handlebars.scala copied to clipboard

Published 20 hours ago • verified publisher icon mwunsch

Cross compile to 2.12.0?

Open daviddenton opened this issue 9 years ago • 9 comments

Is there a plan to add support for the new Scala version? I don't mind submitting a PR to get it done (assuming it's not blocked), but would like to know that it would get released.

:)

daviddenton avatar Nov 09 '16 16:11 daviddenton

This would be cool, any plans on that?

brthanmathwoag avatar Dec 04 '16 17:12 brthanmathwoag

I went ahead and sent PR #74 to cross-compile to 2.12. I really need this myself (this dependency is the final one keeping me from upgrading to 2.12), hope we can move forward with this.

haakonn avatar Feb 15 '17 13:02 haakonn

As a workaround I use this fork for now: https://github.com/daviddenton/handlebars.scala

gaydenko avatar Mar 06 '17 23:03 gaydenko

Hi, @haakonn has kindly put in a PR for this. Is there anybody with merge privs that can merge that PR in please?

agustafson avatar Jun 06 '17 10:06 agustafson

Any updates on this? I'm blocked by it as well and am going to end up using the fork.

It looks like there are at least two open PRs addressing this (#74 and #79); @mwunsch what would it take to get one of those merged?

mkantor avatar Jan 14 '19 16:01 mkantor

Alternatively, if this project is now abandoned/unmaintained and this is not ever going to happen (which I suspect might be the case), could you let us know @mwunsch?

I'd be happy to open a PR to update the README with a note mentioning that and referring people to the fork (if that sounds reasonable).

mkantor avatar Jan 14 '19 16:01 mkantor

@mkantor if you want to do the PR work of upgrading my fork to support 2.12 then I'll look at releasing it. I'm not sure what it will take in terms of SBT shenanigans though... :)

daviddenton avatar Jan 14 '19 17:01 daviddenton

work of upgrading my fork to support 2.12

@daviddenton Hmm, based on @gaydenko's comment and the artifacts in Maven Central, I thought that your fork was already compatible with 2.12 (but admittedly I haven't tried it yet). What's left to do?

Also let me know if you'd prefer to take this discussion elsewhere; I'm happy to chat via whatever medium is most convenient for you.

mkantor avatar Jan 14 '19 17:01 mkantor

@mkantor lol. Looks like you're right! I admit that I totally forgot publishing this for 2.12 (it was a while ago). If anyone else wants to grab the reins of this fork then please speak up, since I'm not currently working on any Scala projects so I probably won't be paying attention when 2.13 comes around.

daviddenton avatar Jan 14 '19 23:01 daviddenton