rsolr-ext icon indicating copy to clipboard operation
rsolr-ext copied to clipboard

:start param ignored in 1.0.3?

Open danfunk opened this issue 14 years ago • 4 comments

Previously Find would respect the inclusion of a :start param (rather than :page) but in v 1.0.3 the :start parameter is ignored if :per_page is specified. I think the cause is on line 18 of client.rb where you check for either a :page or a :per_page parameter.

danfunk avatar Jun 14 '11 20:06 danfunk

I can confirm this behavior (introduced by commit 39601f90). In previous versions of rsolr-ext, as part of your query, you could provide the solr "rows" parameter. With rsolr-ext 1.0.3, you instead need to provide (exclusively) rsolr's page/per_page parameters. Any chance we could get the old behavior restored, in addition to the new rsolr paginate style?

cbeer avatar Jun 21 '11 12:06 cbeer

matt, any comment?

jrochkind avatar Jun 30 '11 19:06 jrochkind

this is trickling down to cause increasingly weird bugs in our code.

Solr "start" is 0-indexed, and also is an index into number of documents. RSolr#page is 1-indexed, and indexed into number of pages. Not the same thing at all. To remove our ability to use ordinary Solr#start is causing all sorts of hard to find bugs.

jrochkind avatar Jun 30 '11 19:06 jrochkind

+1

knewter avatar Mar 02 '12 20:03 knewter