go-proto-validators icon indicating copy to clipboard operation
go-proto-validators copied to clipboard

Do not force dependants to depend on bazel_gazelle

Open fmeum opened this issue 3 years ago • 1 comments

By loading the "gazelle" rule from @bazel_gazelle in the top-level build file, all users of targets in that file have to depend on bazel_gazelle. This is particular problematic for rules_go, which depends on //:validators_golang but should not depend on bazel_gazelle.

This is resolved by moving the gazelle rule definition into a separate Bazel package.

fmeum avatar Jan 16 '22 18:01 fmeum

Friendly ping, can this be reviewed?

fmeum avatar Apr 13 '22 20:04 fmeum

@devnev @Helcaraxan Friendly ping. Could you review this change? It's very small, but would unblock using this package with Bazel's new external dependency management.

fmeum avatar Oct 15 '22 09:10 fmeum

@devnev Thanks for the approval! Could you merge?

fmeum avatar Oct 23 '22 20:10 fmeum