Mats Wichmann

> @mwichmann Is this still viable, or should it be closed? Well, the state hasn't changed: ninja (mildly) misuses some stuff, and "fixing" it causes some tests to go awry,...

I'll revisit this someday, no need to have it hanging around here for now.

Hey - this looks very comprehensive work! Wanted to note that with a dark theme (which I didn't pick, by the way, assorted defaults get me there for GitHub web...

> Is there a difference? Having trouble reproducing. > > Edit: should be fixed now. Yes, it's fine. It was only a minor nit - thanks!

Yeah a bit off-topic, but "dark themes" have problems with this, as there's often some color assumption somewhere that doesn't work, I'm not really a fan, but sometimes it's too...

Does this PR, which I haven't had a chance to actually review, deal with the versioning problem we anticipated, that is now actual? 16.10 has dropped, and with current code,...

Yeah, a bunch of not-found type of things in the failing tests, ``` Failed the following 7 tests: SCons\Tool\MSCommon\MSVC\ScriptArgumentsTests.py SCons\Tool\MSCommon\vcTests.py test\MSVC\msvc_cache_force_defaults.py test\MSVC\MSVC_SDK_VERSION.py test\MSVC\MSVC_SPECTRE_LIBS.py test\MSVC\MSVC_TOOLSET_VERSION.py test\MSVC\MSVC_UWP_APP.py ```

Couple of example test outputs... of course this is not as comprehensive as the debug logs, which I didn't capture in the initial run. ``` ERROR: test_msvc_script_args (__main__.ScriptArgumentsTests.test_msvc_script_args) ---------------------------------------------------------------------- Traceback...

I'll create a new issue if we don't have one - I remember kicking the potential problem around a few times before. It seems the regexes fail here, as you...

> @mwichmann Where can I find what is installed in the new windows Full Test Suite? > > The test is still in progress and at least one test (SCons\Tool\MSCommon\vcTests.py)...