Matt Campbell

Results 95 comments of Matt Campbell

I'm doing this as a draft for now because it's a bit quick and dirty, doesn't yet expose the bounding rectangles of runs and the relative positions and widths of...

Forgot to mention: This is known to work on Windows, when editing or moving in a textbox and when using NVDA's review commands within a prose widget like the one...

FOrtunately, AccessKit never sends action requests to the individual runs. I'll address the rest of the comments later.

Also to clarify a previous comment, this code should be as functional on macOS and Linux as it is on Windows. I just haven't tested on those platforms yet.

I wonder if I should move this out of draft and plan to land it without filling in the positions of the runs and characters for now. FWIW, one non-Rust...

Also, I left in a TODO comment speculating about adding a trailing newline to the run node if it's at the end of a line that's not the last line...

Taking this out of draft because we agreed we'd land this PR without bounding boxes for runs and positions/widths of characters.

I believe I've now adequately addressed all review feedback.

@PoignardAzur Please review again when you have time. Thanks.

@PoignardAzur Requesting final approval after my last changes.