Espresso
Espresso copied to clipboard
Fixes issue #72, where only the first of multiple resources sharing the ...
...same base name would get included in the application
We will review this. Sounds great, but we have to investigate for potential unwanted implications...
I think we need to handle this differently. Imagine you are using a 3rd-party framework with a file called "core.js". Then, with the current implementation + this pull request, this file would overwrite the framework's "core.js" since they all are pushed to the same directory.
So what I think we need to do is:
- check for the path (as you do with this pull request)
- check for the basename + extension and eventually rename the file
Example: myproj/frameworks/The-M-Project/ myproj/frameworks/a3rdpartyframework/core.js
==> core.js (The-M-Project) core.js (a3rdpartyframework) --> basename + extension already exists --> rename --> e.g. a3rdpartyframework_core.js
What do you guys think about that?
Best regards Dominik