Michael Waskom
Michael Waskom
@prbot revoke
hm, that didn't do the trick
Closing as stale and superseded by the method pooling PR.
What effect does this have?
This was just a genuine question on my end; it’s not clear from the example what this is supposed to accomplish. (Are you setting the region you are connecting from?...
Thanks for adding the comments, makes a lot more sense. So that they remain readable, can we move the comments to a line above the parameter and wrap them at...
Also can we prefix the location with an underscore (e.g. `_vendor` so that it doesn't get confused for public API?
What is our approach to tests going to be with vendored code? Are we just going to assume that our existing unit tests cover all the behaviors that we need?
It also feels like we want some way of tracking what version the vendored code is sourced from. How will we know when we need to update it, e.g. if...
Now is probably the only time we will know what version this corresponds to though :)