Moritz Warning
Moritz Warning
@iddq settings_mode is more of an ad-hoc setting that does not have to be persistent. It only is reset when Meshenger is restarted. It is not a strong argument though.
Well, we can make it a persistent setting. I do not mind.
Hi @IzumiSenaSora, I consider the App to be more or less feature complete. There will be bug fixes, updates and minor usability improvements. But nothing bigger is planed as part...
oh, nice find. All those scenarios were definetly not tested.
I do not see that a port == 0 will be omited from the QR code: https://github.com/mwarning/trigger/blob/master/app/src/main/kotlin/app/trigger/QRShowActivity.kt#L52 But I haev not tested it yet - tomorrow.
To remove Boolean that are false and integers that are 0 would rely on that those are always defaults. D different trigger versions might have different defaults. Without a good...
The timeout change is fine.
It is a good convention to keep defaults to false and 0. But there is no guarantee. Unless there is a very good reason, I would like to keep all...
sorry I had to veto against the approach. I had a very similar idea back then. But then decided to play it safe.
1. the maximum timeout is 5000 (ms). Just because I imagined it would be enough even for slow devices. Feel free to suggest a new maximum timeout. 3. please test...