karibu-testing icon indicating copy to clipboard operation
karibu-testing copied to clipboard

ErrorView not working on 2.1.5 version

Open avdhootu27 opened this issue 9 months ago • 7 comments

I have an error view in my vaadin app which is supposed to be shown when user tries to open a view which doesn't exist. When I was on vaadin 23 and karibu-testing-v10-spring 1.3.24, I had a test running successfully in which I was navigating to a view which doesn't exist, and I was testing if it returns my ErrorView. Now I am on vaadin 24.3.10 and karibu-testing-v10-spring 2.1.5, the test is failing, it is returning the home (default) view. Why this test is failing on vaadin 24 karibu 2.1.5? The expected behaviour is it returns ErrorView.

avdhootu27 avatar May 02 '24 11:05 avdhootu27

Can you please provide a simple code which reproduces the issue?

mvysny avatar May 02 '24 11:05 mvysny

@mvysny Here are 2 projects which has ErrorView functional (in both), one with vaadin 23, karibu 1.3.24 and another with vaadin 24 and karibu 2.1.5.

In vaadin 23 and karibu 1.3.24, the test is passing In vaadin 24 and karibu 2.1.5, the test is not passing (ErrorView is not getting rendered in test)

Functionality wise both are working as expected. flow-spring-examples-v24.zip flow-spring-examples-v23.zip

avdhootu27 avatar May 08 '24 06:05 avdhootu27

@mvysny will it be fixed in upcoming releases?

avdhootu27 avatar May 14 '24 06:05 avdhootu27

@mvysny any update?

avdhootu27 avatar Jul 05 '24 05:07 avdhootu27

Could be related to #161

mvysny avatar Jul 05 '24 09:07 mvysny

Could be that you're using access checker and thus you're being hit by #161. #161 is fixed, closing this one as fixed as well. Please test with Karibu-Testing 2.1.7 and let me know whether it works.

mvysny avatar Aug 01 '24 07:08 mvysny

Tried 2.1.7 and 2.1.8, it doesn't work

avdhootu27 avatar Aug 05 '24 07:08 avdhootu27