Michael Voříšek

Results 926 comments of Michael Voříšek

please the the catch example in the description

> Why can’t you catch a less specific exception there? two examples: - https://github.com/atk4/data/blob/231547f71a52c28587fe25cd9aeddc9699b9e781/src/Schema/Migrator.php#L390 - https://github.com/atk4/data/blob/231547f71a52c28587fe25cd9aeddc9699b9e781/tests/Schema/MigratorTest.php#L71 I temporary fixed it with a custom exception convertor middleware: https://github.com/atk4/data/blob/231547f71a52c28587fe25cd9aeddc9699b9e781/src/Persistence/Sql/DbalDriverMiddleware.php#L135 but I belive...

Why do the more specific exception classes exists then? It works perfectly for all DB vendors except MSSQL, thus I expect this to be fixed, so `TableNotFoundException` can be caught...

@morozov this is more or less typo, as `addUniqueIndex` method https://github.com/doctrine/dbal/blob/3.3.7/src/Schema/Table.php#L237 uses `uniq`, but `_addUniqueConstraint` does not.

> If it's a typo that doesn't change any behavior, why does this code exist in the first place? it depends if the unique index is created using a constructor...

I changed the target to 3.4.x. As discussed above, the code is basically on 2 places, it is a typo fix, thus no extra test added. I belive it can...

I was on holidays, please reopen this issue, although the issue should be obvious (as the 2nd name in the comparsion is unquoted), I am happy to provide a test.

Please note this PR requires https://github.com/doctrine/dbal/pull/5490 for the test, let's resolve/merge that PR first.

@morozov I am sorry to write here in an unrelated issue, but I need to react to https://github.com/doctrine/dbal/pull/5537#issuecomment-1196865769. I have observed 2 (3 when counting the php.ini configuration on my...