Michael Voříšek
Michael Voříšek
> > > another example that could be fixed: > > ```diff > - !($foo instanceof Foo) > + !$foo instanceof Foo > ``` I agree, please submit as a...
@SpacePossum in https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/6409 you write: > some of the cases raised here https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/4997 , but not all what are the missing cases? currently I see PHP CS Fixer can fix:...
> > if (!($object instanceof static)) { > > Can be fixed using `no_unneeded_control_parentheses` using the `negative_instanceof` configuration option (I think that is what you are looking for). it seems...
@brettz9 to prevent any confusin, I have removed any `@example` mention a posted a full jsdoc here that should be kept as is after the fixer is run.
To what part of the comment is the `Example:` text aligned now? End of `@param name` a few lines above?
> I actually think it should be aligning after `@param shortHand [bool]` and with the description per test cases like: > ... yes, and if there is extra blank line...
the main problem is the description below the jsdoc tags, when moved above (above `@param`), the "large indentaion" problem is gone
Usecases? What is "weak" and when? Sometimes traversing should be weak, sometimes not, we should probably start with all possible usecases and then find a well understandable solution.
please make the CS/stan CI happy and unit testing to finish at least this is good practice so we can focus on the real issues
it would be great if you can add a simple model code