Marius Vollmer

Results 484 comments of Marius Vollmer

> Current [expanded view] is fine for maximizing space. But we should in future PR fix this.. I don't like how the page loses all the spacing, border, and border...

@Venefilyn, for me the "Edit VNC settings" dialog is in the "non guided" part of Cockpit. It's there if you really need it, but otherwise it is best ignored. The...

> When it becomes a lot of options, having a tab selection might not be the best way to switch either. Yes, agreed. I think it is very rare that...

Oh no, the tests have entered flake town...

@martinpitt, ready for your review! Note there are numerous FIXUP commits addressing previous review comments. Would you like me to squash them?

Test failure notes: - Spice is not a thing on rhel-10-1 anymore - Expanded console pixel test is racy? - Popover pixel test has noise behind the rounded corners.

Squashed and updated commit message.

https://github.com/cockpit-project/pixel-test-reference/compare/422bdab1848efde0d876af4fe7cef842601442f5..38020f216d7025ee04b1a91d3728d8b68f73bccd#diff-dce65d44b874dc9f319800d89a238313f76b66547690c589753a2b47f158bb60 is bogus... Also TestMachinesConsoles-testMultiHostExternalConsole-popover-medium-pixels.png

No idea how TestMachinesNICs-testVmNICs-vm-details-nics-card-edit-disabled-dark-pixels.png got in here....

> Thanks! Remaining pain points: > > * The [new spice medium screenshot](https://github.com/cockpit-project/pixel-test-reference/compare/f2cfde6e34b917b534882ac22c748e3e859bc2c2..38020f216d7025ee04b1a91d3728d8b68f73bccd#diff-dce65d44b874dc9f319800d89a238313f76b66547690c589753a2b47f158bb60) still looks broken? This is supposed to be the "Remote viewer" popup, but it has moved itself...