Michael Vogt

Results 137 comments of Michael Vogt

That is a very good question. There may well be none, I stumbled over this when looking into https://github.com/python/typeshed/issues/3107 which is claimed to be fixed in pyright but open still...

> I feel like; while it is useful for its performance improvements over the current curl stage, it seems to make the curl stage a lot more complex with all...

Had to do another rebase/conflict resolution because of https://github.com/osbuild/osbuild/pull/1809

> There's a fixup! commit in the PR, otherwise LGTM. Sorry for that! I removed that one now and it should be good again.

> I'd rather really push this down lower e.g. to > > https://github.com/osbuild/image-builder/blob/d22e4de51ffa49722179da18106ef0519f7446db/internal/clients/composer/client.go#L76 > > Any concerns? (I'll check next week if it's possible ) I looked at this too...

> > I'd rather really push this down lower e.g. to > > https://github.com/osbuild/image-builder/blob/d22e4de51ffa49722179da18106ef0519f7446db/internal/clients/composer/client.go#L76 > > > > Any concerns? (I'll check next week if it's possible ) > >...

Closing in favor of the simpler fix on the envoy level

> Just a quick thought: would it be valueable to go over the actual log statements, and find a better level for them so the default behaviour is sane? Sure,...

Thanks for the issue report and sorry for the slow reply. The latest code in bib will honor the `ID_LIKE` field and also inverted the logic for searching for lorax...

This looks like an issue that fits the "images" repo better, is that correct @achilleas-k ?