bevy_egui icon indicating copy to clipboard operation
bevy_egui copied to clipboard

Update to egui 0.25.0

Open MickHarrigan opened this issue 1 year ago β€’ 1 comments
trafficstars

The only major thing of note here is in src/systems.rs where a new Key field is introduced that takes both the key that is pressed and a physical key that allows non-qwerty users to still use the same layout.

I don't know if this should be used out of the gate yet or if there should be more thought before it gets utilized. Wouldn't mind any input on this.

MickHarrigan avatar Jan 09 '24 02:01 MickHarrigan

Converted this to a draft as with some further digging the PRs in both bevy_input and egui that updated the winit crate to 0.29 have a bit more nuance to them that this change should take note of. I will continue to read through their changes and see what is the best course of action soon.

Edit: after reading through both the changes it seems that the winit changes have yet to come through on the bevy side so the logical key wouldn't be properly reflected yet. Thus I believe that the change that I already made should be good until bevy releases a new version that uses the winit updates.

If I missed something or you disagree feel free to reach out about it.

MickHarrigan avatar Jan 09 '24 18:01 MickHarrigan

Now with https://github.com/bevyengine/bevy/pull/11400 ; from KeyboardInput, we can now use key_code for physical key, and logical_key for logical key.

ThierryBerger avatar Feb 03 '24 20:02 ThierryBerger

https://github.com/emilk/egui/releases/tag/0.26.0 is also now available.

xangelix avatar Feb 05 '24 16:02 xangelix

Egui 0.26 is now in main, thanks for the PR!

vladbat00 avatar Feb 19 '24 19:02 vladbat00