jk2mv icon indicating copy to clipboard operation
jk2mv copied to clipboard

Fixed compilation issue for ARM architecture

Open raphaelM-sudo opened this issue 2 years ago • 2 comments

Was not able to compile on ARM without those changes.

raphaelM-sudo avatar Oct 18 '22 05:10 raphaelM-sudo

Thanks for the pull request!

I am not sure if this is just a display error on mobile devices, but it looks like your commit also changed the reference for the mvsdk submodule to a commit that is not publicly available on GitHub.

If this is actually the case it would be nice if you could rebase your branch to not contain the mvsdk change.

Daggolin avatar Oct 18 '22 05:10 Daggolin

Hi, it also required a change in mvsdk and I messed up the pull request with the submodule. I will try to update the PR

raphaelM-sudo avatar Oct 18 '22 05:10 raphaelM-sudo

Hey, I tried to merge it but this branch is all messed up with submodule stuff. It won't even fetch for me. You can fix it (rebase or make a new branch with just CMakefiles fix) or I'm gonna just commit the fix myself.

aufau avatar Jun 12 '23 17:06 aufau

Hi, yes I had troubles with the mvsdk submodule. The PR got messed up because there were also changes required in mvsdk for the ARM compilation issue to be resolved. Feel free to commit the fix yourself.

raphaelM-sudo avatar Jul 29 '23 09:07 raphaelM-sudo

Merged in d7f8f63c789b6e19b805bb472bcb4e1ea7882b0d

aufau avatar Aug 16 '23 17:08 aufau