CIS-Script icon indicating copy to clipboard operation
CIS-Script copied to clipboard

Published 20 hours ago • verified publisher icon mvdbent

OrgScore 2.3.2 - Issue with code

Open reuven-cohen opened this issue 2 years ago • 2 comments

The current code check for 2.3.2 appears to check whether the Hot Corners are managed, but not what value the corner is set to.

if [[ "${prefIsManaged}" != "6" ]] || [[ "${prefIsManaged2}" != "6" ]] || [[ "${prefIsManaged3}" != "6" ]] || [[ "${prefIsManaged4}" != "6" ]]; then Should be replaced with if [[ "${prefValueAsUser}" != "6" ]] || [[ "${prefValueAsUser2}" != "6" ]] || [[ "${prefValueAsUser3}" != "6" ]] || [[ "${prefValueAsUser4}" != "6" ]]; then

reuven-cohen avatar Jun 07 '22 02:06 reuven-cohen

Correction: if [[ "${prefValueAsUser}" != "6" ]] && [[ "${prefValueAsUser2}" != "6" ]] && [[ "${prefValueAsUser3}" != "6" ]] && [[ "${prefValueAsUser4}" != "6" ]]; then

reuven-cohen avatar Jun 07 '22 03:06 reuven-cohen

sorry for the late answer, but isn't it the case that one setting needs to be set? not all? try to understand why the and (&&) instead of or (||)?

mvdbent avatar Aug 26 '22 07:08 mvdbent